Code updated to the present syntax with corrections to edge conditions#1
Open
Daksh-404 wants to merge 6 commits intoaishack:masterfrom
Open
Code updated to the present syntax with corrections to edge conditions#1Daksh-404 wants to merge 6 commits intoaishack:masterfrom
Daksh-404 wants to merge 6 commits intoaishack:masterfrom
Conversation
Daksh-404
commented
Sep 30, 2020
Daksh-404
commented
- Vectors employed instead of arrays, which made allocation and working of the program smoother and also reducing the lines of code.
- Usage of the latest and newest openCV 4.3 syntax. Thus the following code doesn't use any kind of pointers unlike the past syntax and working.
- Reduction in number of lines of code due to above 2 points
- Significant improvement in boundary conditions along with usage of Mat.at(Point(x,y)) for accessing each and every pixel of the Mat.
liquidmetal
reviewed
Oct 1, 2020
| vector<float> fv; // The feature vector | ||
|
|
||
| Descriptor(float x, float y, vector<double> const& f) | ||
| Descriptor(float x, float y, vector<float> const& f) |
Contributor
There was a problem hiding this comment.
Consider using an initializer list here.
liquidmetal
reviewed
Oct 1, 2020
| // Constructor: Give a preloaded image and provide the desired number | ||
| // of octaves and intervals | ||
| SIFT::SIFT(IplImage* img, int octaves, int intervals) | ||
| //intialising the the meSIFT class |
liquidmetal
reviewed
Oct 1, 2020
|
|
||
| // BuildScaleSpace() | ||
| // This function generates all the blurred out images for each octave | ||
| // This function generates al`l the blurred out images for each octave |
liquidmetal
reviewed
Oct 1, 2020
|
|
||
| class SIFT | ||
| using namespace cv; | ||
| class meSIFT |
liquidmetal
reviewed
Oct 1, 2020
| } | ||
| } | ||
|
|
||
| //cout << endl; |
Contributor
There was a problem hiding this comment.
Commented lines for debugging can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.